fix(s3): s3 bucket routing rules modifications

[ivankatliarchuk]

Description

Relations

Closes #27400

References

Output from Acceptance Testing

Tests not touched

% make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_basic'  -timeout 360m
2024/10/26 18:37:22 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (44.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	61.236s

❯❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_disappears
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_disappears'  -timeout 360m
2024/10/26 18:59:44 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (40.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	57.093s


❯❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_update
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_update'  -timeout 360m
2024/10/26 19:01:51 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_update (73.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	90.360s


❯❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_Redirect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_Redirect'  -timeout 360m
2024/10/26 19:04:02 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (45.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	61.668s

❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_Redirect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_Redirect'  -timeout 360m
2024/10/26 19:19:25 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (45.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	61.876s

❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange'  -timeout 360m
2024/10/26 19:24:26 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (65.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	82.297s


❯❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange'  -timeout 360m
2024/10/26 19:26:51 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (66.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	83.049s

❯ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_directoryBucket
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_directoryBucket'  -timeout 360m
2024/10/26 19:33:01 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketWebsiteConfiguration_directoryBucket
=== PAUSE TestAccS3BucketWebsiteConfiguration_directoryBucket
=== CONT  TestAccS3BucketWebsiteConfiguration_directoryBucket
--- PASS: TestAccS3BucketWebsiteConfiguration_directoryBucket (21.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	38.117s
...

Tests require revisit, as now on routing rule change, there is a diff

make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @ivankatliarchuk 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃