f/aws_firehose_delivery_stream iceberg destination

[sonya]

Description

This commit adds an initial implementation of the iceberg destination type for Firehose delivery streams.

Some notes

• My team would really like to have this feature ASAP, so I hope to be as helpful as possible
• I tried to follow conventions for ordering things, but I didn't quite figure out the conventions for function ordering so I made some arbitrary guesses which may or may not make sense
• I updated one of the markdown files for documentation, but there are several and I'm not sure which one(s) should be updated
• Some formatting changes were added by gofumpt. I can remove them if necessary
• It looks like I might not have the option to check "allow maintainers to make changes" - I can reopen this under my own account if needed

Relations

Proposal for addressing #38753

References

• AWS API reference for IcebergDestinationConfiguration

Output from Acceptance Testing

% make testacc TESTS=TestAccFirehoseDeliveryStream_icebergUpdates PKG=firehose
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/firehose/... -v -count 1 -parallel 20 -run='TestAccFirehoseDeliveryStream_icebergUpdates'  -timeout 360m
2024/10/22 22:11:44 Initializing Terraform AWS Provider...
=== RUN   TestAccFirehoseDeliveryStream_icebergUpdates
=== PAUSE TestAccFirehoseDeliveryStream_icebergUpdates
=== CONT  TestAccFirehoseDeliveryStream_icebergUpdates
--- PASS: TestAccFirehoseDeliveryStream_icebergUpdates (153.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   157.535s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @sonya 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[github-actions]

Welcome @sonya 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

In order to get this merged quickly I rolled the work into #38098.

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!