Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging tests for resiliencehub #39804

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Tagging tests for resiliencehub #39804

merged 5 commits into from
Oct 21, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds tagging tests for resiliencehub

Relations

Relates #38913

References

Output from Acceptance Testing

% make testacc PKG=resiliencehub TESTS=TestAccResilienceHubResiliencyPolicy_tags ACCTEST_PARALLELISM=10

--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag (25.56s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate (28.61s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag (29.31s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (30.65s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace (43.09s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly (43.13s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add (43.20s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag (26.70s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag (54.96s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag (60.00s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace (50.04s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly (50.51s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyMap (33.33s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate (50.93s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags (96.19s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_null (24.64s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping (75.66s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate (52.24s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping (71.41s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add (63.44s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly (83.52s)

@gdavison gdavison requested a review from a team as a code owner October 18, 2024 22:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccResilienceHubResiliencyPolicy_tags' PKG=resiliencehub ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/resiliencehub/... -v -count 1 -parallel 3  -run=TestAccResilienceHubResiliencyPolicy_tags -timeout 360m
2024/10/21 08:10:03 Initializing Terraform AWS Provider...
=== RUN   TestAccResilienceHubResiliencyPolicy_tags
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_null
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_null
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_EmptyMap
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_EmptyMap
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccResilienceHubResiliencyPolicy_tags
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate (18.22s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly (21.84s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag (28.01s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags (49.20s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag (31.40s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag (13.66s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (14.06s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag (13.85s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag (14.15s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace (26.31s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace (22.83s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly (23.43s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping (37.64s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping (38.35s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly (49.07s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate (22.80s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_EmptyMap
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add (34.22s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_null
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyMap (13.85s)
=== CONT  TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate (25.02s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_null (13.50s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add (26.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resiliencehub	196.604s

@gdavison gdavison merged commit 7c4c42d into main Oct 21, 2024
39 checks passed
@gdavison gdavison deleted the td-resiliencehub-tags branch October 21, 2024 21:36
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 21, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants