Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new aws_cloudfront_key_group data source #39701

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

terenho
Copy link

@terenho terenho commented Oct 13, 2024

Description

This PR is to add the new data source for aws_cloudfront_key_group. The data source can be queried by Key Group IDs or Key Group names.

Relations

Closes #28534

Requested Resource(s) and/or Data Source(s)

  • aws_cloudfront_key_group

References

Output from Acceptance Testing

$ make testacc TESTS="TestAccCloudFrontKeyGroupDataSource_" PKG=cloudfront
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontKeyGroupDataSource_'  -timeout 360m
2024/10/26 03:12:53 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontKeyGroupDataSource_basic
=== PAUSE TestAccCloudFrontKeyGroupDataSource_basic
=== RUN   TestAccCloudFrontKeyGroupDataSource_disappears
=== PAUSE TestAccCloudFrontKeyGroupDataSource_disappears
=== RUN   TestAccCloudFrontKeyGroupDataSource_name
=== PAUSE TestAccCloudFrontKeyGroupDataSource_name
=== CONT  TestAccCloudFrontKeyGroupDataSource_basic
=== CONT  TestAccCloudFrontKeyGroupDataSource_disappears
=== CONT  TestAccCloudFrontKeyGroupDataSource_name
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/index.json
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/index.json
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/index.json
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS.72D7468F.sig
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS.72D7468F.sig
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS.72D7468F.sig
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_SHA256SUMS
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_linux_amd64.zip
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_linux_amd64.zip
2024/10/26 03:12:54 [DEBUG] GET https://releases.hashicorp.com/terraform/1.9.8/terraform_1.9.8_linux_amd64.zip
--- PASS: TestAccCloudFrontKeyGroupDataSource_disappears (8.66s)
--- PASS: TestAccCloudFrontKeyGroupDataSource_basic (30.34s)
--- PASS: TestAccCloudFrontKeyGroupDataSource_name (30.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	31.326s
$

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. needs-triage Waiting for first response or review from a maintainer. labels Oct 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @terenho 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 15, 2024
@terenho terenho changed the title initial cloudfront data source key group [New Data Source]: aws_cloudfront_key_group Oct 16, 2024
@github-actions github-actions bot added the generators Relates to code generators. label Oct 16, 2024
@terenho terenho changed the title [New Data Source]: aws_cloudfront_key_group [WIP] [New Data Source]: aws_cloudfront_key_group Oct 16, 2024
@terenho terenho changed the title [WIP] [New Data Source]: aws_cloudfront_key_group [WIP] feat: Add new aws_cloudfront_key_group data source Oct 16, 2024
@terenho terenho force-pushed the f-cloudfront-key-group branch 4 times, most recently from 7fa21bf to 8aebf9f Compare October 26, 2024 04:20
@terenho terenho changed the title [WIP] feat: Add new aws_cloudfront_key_group data source feat: Add new aws_cloudfront_key_group data source Oct 26, 2024
@terenho terenho marked this pull request as ready for review October 26, 2024 04:23
@terenho terenho requested a review from a team as a code owner October 26, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: cloudfront_key_group
2 participants