Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53profiles_profile: fix inconsistent result on tags update #39613

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 7, 2024

Description

Various computed attributes on the aws_route53profiles_profile resource were missing UseStateForUnknown plan modifiers, causing tag updates to fail. A changelog entry is not necessary for this fix as this resource has not yet been formally released.

        Error: Provider returned invalid result object after apply

        After the apply operation, the provider still indicated an unknown value for
        aws_route53profiles_profile.test.status_message. All values must be known
        after apply, so this is always a bug in the provider and should be reported
        in the provider's own repository. Terraform will still save the other known
        object values in the state.

Relations

Relates #38172

References

Output from Acceptance Testing

% make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesProfile_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesProfile_'  -timeout 360m

--- PASS: TestAccRoute53ProfilesProfile_disappears (13.83s)
--- PASS: TestAccRoute53ProfilesProfile_basic (16.47s)
--- PASS: TestAccRoute53ProfilesProfile_tags (34.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    39.581s

Various computed attributes on the `aws_route53profiles_profile` resource were missing `UseStateForUnknown` plan modifiers, causing tag updates to fail. A changelog entry is not necessary for this fix as this resource has not yet been formally released.

```console
% make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesProfile_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesProfile_'  -timeout 360m

--- PASS: TestAccRoute53ProfilesProfile_disappears (13.83s)
--- PASS: TestAccRoute53ProfilesProfile_basic (16.47s)
--- PASS: TestAccRoute53ProfilesProfile_tags (34.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    39.581s
```
Copy link

github-actions bot commented Oct 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53profiles Issues and PRs that pertain to the route53profiles service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 7, 2024
@jar-b jar-b marked this pull request as ready for review October 7, 2024 19:00
@jar-b jar-b requested a review from a team as a code owner October 7, 2024 19:00
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesProfile_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesProfile_'  -timeout 360m
=== RUN   TestAccRoute53ProfilesProfile_basic
=== PAUSE TestAccRoute53ProfilesProfile_basic
=== RUN   TestAccRoute53ProfilesProfile_disappears
=== PAUSE TestAccRoute53ProfilesProfile_disappears
=== RUN   TestAccRoute53ProfilesProfile_tags
=== PAUSE TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_basic
=== CONT  TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_disappears
--- PASS: TestAccRoute53ProfilesProfile_disappears (13.23s)
--- PASS: TestAccRoute53ProfilesProfile_basic (15.43s)
--- PASS: TestAccRoute53ProfilesProfile_tags (30.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    35.643s

@jar-b jar-b merged commit d323d20 into main Oct 7, 2024
53 checks passed
@jar-b jar-b deleted the b-r53profile branch October 7, 2024 19:50
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 7, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/route53profiles Issues and PRs that pertain to the route53profiles service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants