-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_route53profiles_profile: fix inconsistent result on tags update #39613
Conversation
Various computed attributes on the `aws_route53profiles_profile` resource were missing `UseStateForUnknown` plan modifiers, causing tag updates to fail. A changelog entry is not necessary for this fix as this resource has not yet been formally released. ```console % make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesProfile_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesProfile_' -timeout 360m --- PASS: TestAccRoute53ProfilesProfile_disappears (13.83s) --- PASS: TestAccRoute53ProfilesProfile_basic (16.47s) --- PASS: TestAccRoute53ProfilesProfile_tags (34.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles 39.581s ```
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesProfile_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesProfile_' -timeout 360m
=== RUN TestAccRoute53ProfilesProfile_basic
=== PAUSE TestAccRoute53ProfilesProfile_basic
=== RUN TestAccRoute53ProfilesProfile_disappears
=== PAUSE TestAccRoute53ProfilesProfile_disappears
=== RUN TestAccRoute53ProfilesProfile_tags
=== PAUSE TestAccRoute53ProfilesProfile_tags
=== CONT TestAccRoute53ProfilesProfile_basic
=== CONT TestAccRoute53ProfilesProfile_tags
=== CONT TestAccRoute53ProfilesProfile_disappears
--- PASS: TestAccRoute53ProfilesProfile_disappears (13.23s)
--- PASS: TestAccRoute53ProfilesProfile_basic (15.43s)
--- PASS: TestAccRoute53ProfilesProfile_tags (30.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles 35.643s
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Various computed attributes on the
aws_route53profiles_profile
resource were missingUseStateForUnknown
plan modifiers, causing tag updates to fail. A changelog entry is not necessary for this fix as this resource has not yet been formally released.Relations
Relates #38172
References
Output from Acceptance Testing