-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/dynamodb_tag: change equality check in propagation waiter #39491
Merged
Merged
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
71a665b
add tags comparator option to generator
johnsonaj 09801a9
dynamodb: waitfunc use ContainsAll()
johnsonaj eecaae4
aws_dynamodb_tag: add test for multiple tag resources
johnsonaj 0176619
Merge branch 'main' into b-dynamodb_tags_propagation
johnsonaj a2c3340
aws_dynamodb_table: add generated tags tests
johnsonaj dac6e5b
aws_dynamodb_table: add generated tags tests
johnsonaj 33de098
revert tags generator comparator change
johnsonaj 53f682d
tags: factor out checkFunc
johnsonaj d599a8a
generate func for updating single tag resource
johnsonaj 0386294
update tag resource to use new updatesTagsForResource func
johnsonaj ac151e4
make gen
johnsonaj 6b8b2e0
cleanup
johnsonaj 7ee33f8
generate separate checkFunc
johnsonaj 92e2a00
Revert "revert tags generator comparator change"
johnsonaj 3e86c38
generate updateTagsForResource
johnsonaj d5817ba
add CHANGELOG entry
johnsonaj c398c7c
tweak CHANGELOG entry
johnsonaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍