fix: fix typo in mapping for cascading_control_configuration

[stefanfreitag]

Description

The internally used key cacading_control_configuration contains a typo, so that the mapping fails.

Relations

Closes #39139

References

• Cloudformation User Guide

Output from Acceptance Testing

TDB - I would need to check how to provide a test for the fix.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[stefanfreitag]

I would need some guidance on the testing part:

• The dashboard definition is part of the initial issue, but I think it needs to be stripped down to the minimum for the test. For this the access to Quicksight somehow makes sense.
• At the moment I do not have access to Quicksight itself and there seems to be cost involved when it comes to creation of the dashboards/ being an Admin in that service.

How would I need to proceed here?

[ewbankkit]

It looks like there's another one in internal/service/quicksight/schema/template_control.go.

[stefanfreitag]

Agree, I missed that one - thanks for taking time and doing this consistency check!

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccQuickSightDashboard_' PKG=quicksight ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/quicksight/... -v -count 1 -parallel 3  -run=TestAccQuickSightDashboard_ -timeout 360m
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightDashboard_sourceEntity
--- PASS: TestAccQuickSightDashboard_basic (39.94s)
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
--- PASS: TestAccQuickSightDashboard_sourceEntity (41.68s)
=== CONT  TestAccQuickSightDashboard_disappears
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (74.14s)
--- PASS: TestAccQuickSightDashboard_disappears (34.95s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (38.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	83.703s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.593s [no tests to run]

[ewbankkit]

@stefanfreitag Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.