Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace bad .Resource ref with .DataSource in datasourcefw.gtpl #39208

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Sep 7, 2024

Description

This PR is to replace the invalid variable reference .Resource with .DataSource in datasourcefw.gtpl which prevented skaff datasource from being run successfully to generate new data source artifacts.

Relations

Closes #39207

References

n/a

Output from Acceptance Testing

$ cd internal/service/synthetics
$ skaff datasource -f -n RuntimeVersion

$

Source code and documentation are generated successfully.

@acwwat acwwat requested a review from a team as a code owner September 7, 2024 05:17
Copy link

github-actions bot commented Sep 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added skaff Issues and pull requested related to the skaff tool needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Sep 7, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Sep 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Member

jar-b commented Sep 9, 2024

Thanks for the fix, @acwwat! 👍

@jar-b jar-b merged commit 52497bc into hashicorp:main Sep 9, 2024
14 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the b-skaff-fix_datasource_tpl_var_refs branch September 16, 2024 00:12
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-maintainer Contribution from a trusted external contributor. skaff Issues and pull requested related to the skaff tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: skaff datasource fails with "can't evaluate field Resource in type datasource.TemplateData" error
2 participants