-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new aws_synthetics_runtime_verison and aws_synthetics_runtime_verisons data sources #39180
Merged
jar-b
merged 9 commits into
hashicorp:main
from
acwwat:f-aws_synthetics_runtime_versions-new_data_source
Sep 18, 2024
Merged
feat: Add new aws_synthetics_runtime_verison and aws_synthetics_runtime_verisons data sources #39180
jar-b
merged 9 commits into
hashicorp:main
from
acwwat:f-aws_synthetics_runtime_versions-new_data_source
Sep 18, 2024
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9475b29 - Browse repository at this point
Copy the full SHA 9475b29View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaa0654 - Browse repository at this point
Copy the full SHA aaa0654View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6e9a8d - Browse repository at this point
Copy the full SHA f6e9a8dView commit details -
internal/framework/validators: add BoolEquals validator
```console % go test -count=1 ./internal/framework/validators/... ok github.com/hashicorp/terraform-provider-aws/internal/framework/validators 0.492s ```
Configuration menu - View commit details
-
Copy full SHA for 04ffe0e - Browse repository at this point
Copy the full SHA 04ffe0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ac8267 - Browse repository at this point
Copy the full SHA 5ac8267View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c04d79 - Browse repository at this point
Copy the full SHA 0c04d79View commit details -
d/aws_synthetics_runtime_versions: add runtime_versions, rm skip_depr…
…ecated This change returns a data structure more closely matching the `DescribeRuntimeVersions` API result. It also removes the `skip_deprecated` argument, as the ability to use the `latest` argument on the `aws_synthetics_runtime_version` data source eliminates much of the need to exclude deprecated versions from the result set. ```console % make testacc PKG=synthetics TESTS=TestAccSyntheticsRuntimeVersion make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsRuntimeVersion' -timeout 360m --- PASS: TestAccSyntheticsRuntimeVersionsDataSource_basic (10.21s) --- PASS: TestAccSyntheticsRuntimeVersionDataSource_deprecatedVersion (10.21s) --- PASS: TestAccSyntheticsRuntimeVersionDataSource_basic (10.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 16.489s ```
Configuration menu - View commit details
-
Copy full SHA for 22448f5 - Browse repository at this point
Copy the full SHA 22448f5View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21884f6 - Browse repository at this point
Copy the full SHA 21884f6View commit details -
r/aws_synthetics_canary(test): use runtime version data source
This eliminates the dependency on hardcoded runtime versions which become deprecated over time and can cause test failures. ```console % make testacc PKG=synthetics TESTS=TestAccSyntheticsCanary_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_' -timeout 360m --- PASS: TestAccSyntheticsCanary_tags (94.55s) --- PASS: TestAccSyntheticsCanary_runtimeVersion (129.64s) --- PASS: TestAccSyntheticsCanary_runTracing (144.68s) --- PASS: TestAccSyntheticsCanary_startCanary (194.92s) --- PASS: TestAccSyntheticsCanary_run (216.00s) --- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (219.09s) --- PASS: TestAccSyntheticsCanary_artifactEncryption (237.15s) --- PASS: TestAccSyntheticsCanary_disappears (470.10s) --- PASS: TestAccSyntheticsCanary_s3 (559.86s) --- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (586.04s) --- PASS: TestAccSyntheticsCanary_basic (606.08s) --- PASS: TestAccSyntheticsCanary_rate (678.13s) --- PASS: TestAccSyntheticsCanary_vpc (2180.95s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 2187.415s ```
Configuration menu - View commit details
-
Copy full SHA for 6d178c0 - Browse repository at this point
Copy the full SHA 6d178c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.