-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F aws workspaces directory dedicated tenancy #33885
base: main
Are you sure you want to change the base?
F aws workspaces directory dedicated tenancy #33885
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @cloud-manta 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Could somebody maybe take a look at this? |
It'd be great if this could be reviewed! Have a need for this for some environments, would be really helpful. Thanks for taking the time to write the changes. |
any update on this? |
Description
Using the current provider version, every Workspaces directory uses the "shared" tenancy which is unsuitable for
BYOL Workspaces (i.e. Workspaces created from BYOL bundles).
This PR introduces a boolean argument "dedicated_tenancy" which is optional and defaults to "false" so that
no changes need to be made to existing templates.
Output from Acceptance Testing
Skipped acceptance testing since it's a very small change and I don't have the resources to run these tests.
PS: This is my first PR for a public repo so please have patience.