Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F aws workspaces directory dedicated tenancy #33885

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cloud-manta
Copy link

Description

Using the current provider version, every Workspaces directory uses the "shared" tenancy which is unsuitable for
BYOL Workspaces (i.e. Workspaces created from BYOL bundles).
This PR introduces a boolean argument "dedicated_tenancy" which is optional and defaults to "false" so that
no changes need to be made to existing templates.

Output from Acceptance Testing

Skipped acceptance testing since it's a very small change and I don't have the resources to run these tests.

PS: This is my first PR for a public repo so please have patience.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/XS Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. labels Oct 11, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 11, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cloud-manta 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@cloud-manta
Copy link
Author

Could somebody maybe take a look at this?
It's a super small change but it would help us tremendously in our project.
If this feature is not present, we need to provision the Workspaces Directory with a null resource and the templates get really messy...
please let me know if I can help in any way.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@amshaffer
Copy link

It'd be great if this could be reviewed! Have a need for this for some environments, would be really helpful. Thanks for taking the time to write the changes.

@benzaam
Copy link

benzaam commented Sep 17, 2024

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants