Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight_analysis: Correctly expand comparison method #32286

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

g-dx
Copy link
Contributor

@g-dx g-dx commented Jun 29, 2023

Fixes #32285

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 29, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 29, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightAnalysis_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_'  -timeout 180m

--- PASS: TestAccQuickSightAnalysis_forceDelete (45.16s)
--- PASS: TestAccQuickSightAnalysis_disappears (45.24s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (49.18s)
--- PASS: TestAccQuickSightAnalysis_basic (50.19s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (52.92s)
--- PASS: TestAccQuickSightAnalysis_update (88.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 92.107s

@jar-b jar-b merged commit 172409a into hashicorp:main Jul 14, 2023
@jar-b
Copy link
Member

jar-b commented Jul 14, 2023

Thanks for your contribution, @g-dx ! 👍

@github-actions github-actions bot added this to the v5.9.0 milestone Jul 14, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@g-dx g-dx deleted the b-kpi-comparison-method branch July 20, 2023 21:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_quicksight_analysis KPI visual ignores comparison method
3 participants