-
Notifications
You must be signed in to change notification settings - Fork 9.5k
removed cpu_core_count and cpu_threads_per_core #31263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
removed cpu_core_count and cpu_threads_per_core #31263
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @krishnaduttPanchagnula 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi @justinretzolk is there something else i have should be doing for PR approval ? |
Hey @krishnaduttPanchagnula 👋 Thank you for checking in on this! I took a quick glance to check if anything was missing, and it looks like we'll need to add a changelog entry and documentation updates that reflect the changes made. Those things won't hold up the PR review, but are things that will need to be added before we merge. That said, unfortunately I can't provide an ETA on when this will be reviewed/merged due to the potential of shifting priorities. We prioritize by count of 👍 reactions and a few other things (more information on our prioritization guide if you're interested). |
Description
Relations
Closes #31165
References
Output from Acceptance Testing