Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_lightsail_domain_entry #2815

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Dec 31, 2017

lightsail domain entry for #2731

This is my first attempt to implement a new resource. Comments and feedbacks are welcome.

The resource is at least working for now. But I do have a few questions about the implementation.

  1. The resource schema follows the same schema as AWS API for CreateDomainEntryInput,
    UpdateDomainEntryInput, DeleteDomainEntryInput. I'm not sure if it's good idea to flat all into common TypeString. In that case, it will make the implementation a bit easier but break the identical mapping between terraform and AWS API.

  2. Name for the domain entry in AWS API is the full FQDN with domain name. From user perspective, it would be easier to just use a string without domain name. We can append domain name before sending request to AWS. The same concern of identical mapping applies here as well. Still I'm following convention for AWS API.

  3. In AWS API DomainEntry, options is already marked as Deprecated. So I didn't add this parameter at all.

  4. I haven't fully figured out how import works, so support for import is not there yet.

  5. I'd like to validate target argument based on is_alias. AFAIK, ValidateFunc works only for the current argument. I don't have it in mind where similar logic is implemented.

@radeksimko radeksimko added the new-resource Introduces a new resource. label Jan 2, 2018
@bflad bflad added the service/lightsail Issues and PRs that pertain to the lightsail service. label Jan 11, 2018
@loivis loivis changed the title [WIP] New Resource: aws_lightsail_domain_entry New Resource: aws_lightsail_domain_entry Feb 1, 2018
@loivis
Copy link
Contributor Author

loivis commented Aug 10, 2018

I won't be able to continue the work so close it.

@loivis loivis closed this Aug 10, 2018
@loivis loivis deleted the 2731-resource-aws-lightsail-domain-entry branch August 10, 2018 08:05
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/lightsail Issues and PRs that pertain to the lightsail service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants