d/aws_cloudwatch_event_rule: new data source

[paololazzari]

Description

New data source for aws_cloudwatch_event_rule.

Output from Acceptance Testing

$ make testacc TESTS=TestAccEventsRuleDataSource PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsRuleDataSource'  -timeout 180m
=== RUN   TestAccEventsRuleDataSource_basic
=== PAUSE TestAccEventsRuleDataSource_basic
=== CONT  TestAccEventsRuleDataSource_basic
--- PASS: TestAccEventsRuleDataSource_basic (33.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     40.836s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @paololazzari 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[kamilturek]

Hey @paololazzari, thank you for your contribution! 🙌

I left a few comments, I hope you'll find them helpful.
Also, please consider having a look at skaff which is a tool that helps building resources/data sources adhering to best practices.

[kamilturek]

LGTM 👍

$ make testacc TESTARGS='-run=TestAccEventsRuleDataSource_basic' PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2  -run=TestAccEventsRuleDataSource_basic -timeout 180m
=== RUN   TestAccEventsRuleDataSource_basic
=== PAUSE TestAccEventsRuleDataSource_basic
=== CONT  TestAccEventsRuleDataSource_basic
--- PASS: TestAccEventsRuleDataSource_basic (30.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     32.353s

[paololazzari]

bump