-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_cloudwatch_event_rule: new data source #27780
base: main
Are you sure you want to change the base?
d/aws_cloudwatch_event_rule: new data source #27780
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @paololazzari 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @paololazzari, thank you for your contribution! 🙌
I left a few comments, I hope you'll find them helpful.
Also, please consider having a look at skaff
which is a tool that helps building resources/data sources adhering to best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
$ make testacc TESTARGS='-run=TestAccEventsRuleDataSource_basic' PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2 -run=TestAccEventsRuleDataSource_basic -timeout 180m
=== RUN TestAccEventsRuleDataSource_basic
=== PAUSE TestAccEventsRuleDataSource_basic
=== CONT TestAccEventsRuleDataSource_basic
--- PASS: TestAccEventsRuleDataSource_basic (30.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 32.353s
bump |
Description
New data source for
aws_cloudwatch_event_rule
.Output from Acceptance Testing