Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "ci." to rule names in new nosemgreps #25952

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Add "ci." to rule names in new nosemgreps #25952

merged 1 commit into from
Jul 22, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 22, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #24340.
Relates #25927.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 22, 2022
@ewbankkit ewbankkit changed the title Add "ci." to rules names in nosemgreps Add "ci." to rules names in new nosemgreps Jul 22, 2022
@ewbankkit ewbankkit added the linter Pertains to changes to or issues with the various linters. label Jul 22, 2022
@ewbankkit ewbankkit changed the title Add "ci." to rules names in new nosemgreps Add "ci." to rule names in new nosemgreps Jul 22, 2022
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jul 22, 2022
YakDriver
YakDriver approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@ewbankkit ewbankkit merged commit 6e42982 into main Jul 22, 2022
@ewbankkit ewbankkit deleted the td-fix-new-nosemgreps branch July 22, 2022 20:46
@github-actions github-actions bot added this to the v4.24.0 milestone Jul 22, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @YakDriver