Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go version to 1.18.4 #25809

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Bump Go version to 1.18.4 #25809

merged 4 commits into from
Jul 22, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 14, 2022 •
edited
Loading

Bumps Go version to 1.18.4

Output from acceptance testing:

$ make test

?   	github.com/hashicorp/terraform-provider-aws	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	43.652s
?   	github.com/hashicorp/terraform-provider-aws/internal/attrmap	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	1.018s
ok  	github.com/hashicorp/terraform-provider-aws/internal/create	1.936s
ok  	github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable	2.006s
?   	github.com/hashicorp/terraform-provider-aws/internal/experimental/sync	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/flex	2.896s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/allowsubcats	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/checknames	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/customends	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/issuelabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/namescapslist	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters	8.225s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/prlabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/servicelabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/servicesemgrep	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/sweepimp	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/tags/templates/v1	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/tags/templates/v2	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	1.412s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	34.980s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	31.165s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	17.996s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	15.224s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	15.669s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	26.173s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	59.995s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	21.338s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	43.915s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	49.864s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	53.850s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	53.126s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/applicationinsights	61.085s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	65.017s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	40.938s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	36.740s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	32.367s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	27.743s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	37.191s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans	39.415s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	34.869s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	46.542s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	39.822s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	43.224s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	42.416s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	50.294s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	47.640s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	49.634s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	56.208s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	44.589s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	48.635s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	52.124s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	57.808s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	47.981s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	51.510s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	54.011s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	60.761s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	55.340s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications	56.701s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	38.910s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	48.667s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	45.534s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	41.225s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cur	45.234s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	49.305s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	50.767s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	51.503s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dax	46.797s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	47.881s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	50.141s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	49.714s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	47.380s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	42.541s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	41.283s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	54.792s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	45.293s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	53.118s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	68.082s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	41.565s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	47.376s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	36.751s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	43.481s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	47.413s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	49.884s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	31.287s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	41.837s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder	51.010s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	39.549s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	50.506s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	50.852s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	40.843s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	46.648s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	51.275s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	54.250s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	49.413s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	53.128s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	57.111s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glacier	54.236s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	55.797s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	43.539s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	47.173s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/greengrass	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	42.687s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	40.829s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	41.962s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	39.262s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	31.983s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	45.329s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotevents	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	39.750s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	43.731s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	50.552s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	50.465s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	57.197s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics	47.175s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	54.137s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo	60.092s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	60.010s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	53.031s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	61.060s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels	43.136s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager	46.236s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	53.969s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	58.715s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	57.160s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie	52.082s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	55.462s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	51.186s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	59.672s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediastore	53.555s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	57.273s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	51.708s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	53.271s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	51.647s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	45.308s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	43.489s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	47.601s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	49.558s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	53.251s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	52.593s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	52.314s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint	54.950s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pricing	51.132s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	55.362s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	61.729s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	58.105s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	54.943s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	48.988s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	43.816s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	42.332s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi	48.033s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	44.225s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	47.154s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig	39.595s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	44.320s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	44.112s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	47.863s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	59.029s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	41.945s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts	47.966s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	55.765s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	44.407s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	56.221s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	56.010s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo	58.872s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	45.632s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	48.997s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas	53.844s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	48.410s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	48.779s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	51.505s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/signer	49.974s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	44.720s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	50.285s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	49.174s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	45.607s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	47.892s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	42.922s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	44.148s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/swf	44.956s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	47.831s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	43.588s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	44.807s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	40.830s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/waf	24.453s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	25.207s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	28.464s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/worklink	21.848s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	22.306s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	25.337s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tags	1.393s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tfresource	38.429s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys	2.326s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil	0.850s
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	24.932s
ok  	github.com/hashicorp/terraform-provider-aws/names	1.358s
?   	github.com/hashicorp/terraform-provider-aws/version	[no test files]

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. linter Pertains to changes to or issues with the various linters. and removed size/S Managed by automation to categorize the size of a PR. labels Jul 14, 2022
@gdavison gdavison force-pushed the go-1.18 branch 3 times, most recently from 6487436 to d6d704d Compare July 15, 2022 22:27
@ewbankkit
Copy link
Contributor

It looks like Go v1.18.4 is now available in goenv: go-nv/goenv#236.

@gdavison gdavison changed the title Bump Go version to 1.18.3 Bump Go version to 1.18.4 Jul 18, 2022
ewbankkit
ewbankkit approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make
==> Checking that code complies with gofmt requirements...
% make tools
cd tools/providerlint && go install .
cd tools && go install github.com/bflad/tfproviderdocs
cd tools && go install github.com/client9/misspell/cmd/misspell
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
cd tools && go install github.com/katbyte/terrafmt
cd tools && go install github.com/terraform-linters/tflint
cd tools && go install github.com/pavius/impi/cmd/impi
cd tools && go install github.com/hashicorp/go-changelog/cmd/changelog-build
cd tools && go install github.com/rhysd/actionlint/cmd/actionlint
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...
WARN [linters context] nilerr is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] unparam is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

Remove providerlint from the root (it contains vendored dependencies) as it now lives below tools.
Need to update docs/contributing/development-environment.md (and/or the equivalent in #25304) as it mentions the Go version.
Needs a rebase.

I suggest not merging until after this week's release so that we get a full release cycle in nightly CI.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 19, 2022
@gdavison gdavison added this to the v4.24.0 milestone Jul 19, 2022
gdavison added a commit to breathingdust/terraform-provider-aws that referenced this pull request Jul 19, 2022
@gdavison
Updates development environment documentation, related to hashicorp#2…
c3ed41f 
…5809
YakDriver
YakDriver approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ewbankkit ewbankkit mentioned this pull request Jul 22, 2022
Closed
@gdavison gdavison merged commit b6d33b0 into main Jul 22, 2022
@gdavison gdavison deleted the go-1.18 branch July 22, 2022 20:43
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

brittandeyoung pushed a commit to brittandeyoung/terraform-provider-aws that referenced this pull request Aug 10, 2022
@breathingdust @justinretzolk
@zhelding @gdavison @johnsonaj @YakDriver @ewbankkit
Contributor Documentation Refactor (hashicorp#25304)
cddbca1 
* started index html file

* Update index.html

* move index + config up so we aren't showing roadmaps

* add layout

* add roadmaps folder in root

* remove layout header

* fix formatting

* changelog + doc guides

* raising content

* revising raised a PR

* datasource

* move faq up, more PR changes

* change theme

* region edits

* resource name generation

* update index

* last couple large items from checklists file

* cleared checklist page

* enhance index descriptions

* consistent lists

* fix link

* remove duplicate PR doc

* up to prio guide

* consolidate maintaining

* up to date from main (manual merge)

* add wip

* point to fork

* code annotate

* pymdown

* back to md from html landing page

* fix some broken links

* nav complete

* brace cleanup

* new region

* spellcheck

* minor tweaks

* remove para tags

* remove historical roadmaps

* appease linters

* add resource tagging link

* retest top level heading

* few more top level revisions

* top level headings complete

* index capitalization

* index capitalization

* docs lint appeased

* normalize code fencing languages

* remove old roadmap

* remove old roadmap

* clean up links on readme

* fix some dead links

* fix some dead links

* last dead links

* move to hashi org for PR

* fix read handler link

* Update various links in raising a PR, checklist -> list

* Correct links and headers in index and add-a-datasource

* Update link to Core Services in Prioritization Guide

* Correct language, links in development environment

* Change checkboxes to list, update links

* Remove extra whitespace

* Correct links in add-a-new-service

* Remove whitespace, correct documentation path in add-a-new-datasource

* Fix broken links in add-a-new-region

* Update link in add-import-support

* Fix broken link in resource-filtering

* Change checklist to bulletted list, fix links in resource-filtering

* acceptance-tests: fix broken links, checklist->list

* data-handling: update links

* Update links in error-handling

* Update links in retries-and-waiters

* Specify preference for ImportStatePassthrough as import state function

* Update links in provider-design

* Update links in naming

* Add notice re: changelog requirement for bugs + enhancements

* Update links in faq

* Formatting fix

* Remove index from data-handling docs

* Remove index from provider design docs

* Add link / reference to immutable infra as good provider design

* Remove index from retries + waiters docs

* add links to skaff readme

* Apply suggestions from code review

Co-authored-by: Graham Davison <g.m.davison@computer.org>
Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
Co-authored-by: Graham Davison <g.m.davison@computer.org>

* Apply suggestions from code review

Co-authored-by: Graham Davison <g.m.davison@computer.org>
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Graham Davison <g.m.davison@computer.org>
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
Co-authored-by: Graham Davison <g.m.davison@computer.org>
Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com>

* move design section to top

* update link

* remove question link

* settle on draft for preview

* Uses footnote style for repeated links

* Updates PR instructions

* Cleanup

* Updates tag generation documentation

* Cleanup

* Updates resource tagging code documentation

* Fixes function name

* datasource -> data source

* add note about locking closed issues

* typo corrections

* resource filter reorder

* add go sdk page, revamped landing

* test third

* test third

* new nav

* remove top level nav from testing page

* angie/mary

* nav indenti9ng

* move submit an issue

* swap landing pages

* aws go sdk versions

* remove TOCs

* remove redundant warning and move to welcome

* sdk base attempt

* base nav

* typo

* change description

* remove prev/next links

* master to main

* add skaff section

* name as link

* Adds documentation `AwsSdkVersion` flag on tag generator

* Linter fixes

* Adds notes on uses of name generation

* Updates AWS SDK version documentation

* Updates the documentation for adding a new service

* Updates development environment documentation, related to hashicorp#25809

* Update contributor documentation for 'acctest.ProtoV5ProviderFactories', 'acctest.ProtoV5FactoriesAlternate' and 'acctest.ProtoV5FactoriesMultipleRegions'.

* Remove leading 'error ' from wrapped error messages.

* Correct indentation.

* Correct location of 'development-environment.md'.

* Remove 'docs/index.old'.

* yamllint

* linkchecker

* use branch as deploy targetmain

* revert internal changes

* remove contrib/maintain

* allow workflow dispatch

* remove device farm change

* device pool from upstream

Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com>
Co-authored-by: Zoe Helding <zoe.helding@gmail.com>
Co-authored-by: Graham Davison <g.m.davison@computer.org>
Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
Co-authored-by: Graham Davison <gdavison@hashicorp.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @ewbankkit @YakDriver