Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TechDebt]: Replace internal BoolEquals validator with boolvalidator.Equals #39817

Closed
3 tasks
jar-b opened this issue Oct 21, 2024 · 3 comments · Fixed by #39860
Closed
3 tasks

[TechDebt]: Replace internal BoolEquals validator with boolvalidator.Equals #39817

jar-b opened this issue Oct 21, 2024 · 3 comments · Fixed by #39860
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Oct 21, 2024

Description

#39180 introduced a custom validator, BoolEquals. The terraform-plugin-framework-validators repository has now added an equivalent Equals validator in the boolvalidator package, which can replace this custom implementation.

  • Remove custom validator
  • Replace with boolvalidator.Equals
  • Run acceptance tests for the data source utilizing this validator

References

Depends on #39790
Relates #39180
Relates hashicorp/terraform-plugin-framework-validators#232

Would you like to implement a fix?

None

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b jar-b added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Oct 21, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant