-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: aws_network_acls doesnt return tags #38511
Comments
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
Hey @matthewmedway 👋 Thank you for taking the time to raise this! Are you able to supply debug logs (redacted as needed)? That information will likely be key for whoever picks this issue up to look into it. Additionally, can you clarify the version of the AWS Provider that you're using? You can verify this by running |
AFAIK the |
Hi @acwwat, I agree with you on the filter part.
With d.SetId(meta.(*conns.AWSClient).Region)
d.Set(names.AttrIDs, naclIDs) Would an update of the documentation help here? e.g. removing "This data source exports the following attributes in addition to the arguments above" as this seems to be not true. |
Re: aws provider version @justinretzolk (i updated since my initial post)
re @acwwat and @stefanfreitag The data resource for ex: with no filter, no tags are returned, but i get all the acls in my account
ex2: with a filter that returns only 1 id, still no tags
In both examples I am expecting ~7 tags for this acl but none are returned. |
The "...in addition to the arguments above" is used in the documentation across all of our resources and data sources, and I would make the case that it's still true in this case (at least as far as Terraform is concerned). That you're able to reference the tags via interpolation without Terraform throwing an error means that the argument is "exported", regardless of what value is you're presented with. Looking at this more, I'm seeing a few different converging things that are leading to the current behavior. The first worth calling out is the description of the data source, which, as far as I can tell, does not currently appear on the Registry:
In my opinion, this definition is key in interpreting whether this is a bug or working as expected. My interpretation of the following is that this is working as is currently expected, but there's potentially room for enhancements. As of right now, the Updating the schema to accommodate the If only a single NACL ID was returned, it may seem intuitive to include any tags in the |
Terraform Core Version
v1.5.0
AWS Provider Version
1.5.59
Affected Resource(s)
aws_network_acls
Expected Behavior
tags should be returned
Actual Behavior
Tags is null
Relevant Error/Panic Output Snippet
Terraform Configuration Files
Steps to Reproduce
Use the supplied tf config files with a valid acl ID, vpc ID, that has tags in the aws console. No tags are returned
Debug Output
No response
Panic Output
No response
Important Factoids
No response
References
Similar issue where no tags were being returned: #37886
Would you like to implement a fix?
No
The text was updated successfully, but these errors were encountered: