Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Security Lake #29376

Closed
4 tasks done
schuylr opened this issue Feb 13, 2023 · 23 comments · Fixed by #35981
Closed
4 tasks done

[New Resource]: Security Lake #29376

schuylr opened this issue Feb 13, 2023 · 23 comments · Fixed by #35981
Labels
new-data-source Introduces a new data source. new-resource Introduces a new resource. new-service Introduces a new service.
Milestone

Comments

@schuylr
Copy link
Contributor

schuylr commented Feb 13, 2023

Description

Looking to add Security Lake as a new Terraform Resource / Data Source so users with IaC requirements in their production environments can effectively start using this service.

Requested Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "aws_security_lake_data_lake" "example" {
  configurations {
    us-east-1 {
      encryptionKey                 = "string"
      replicationDestinationRegions = ["us-west-2"]
      replicationRoleArn            = "string"
      retentionSettings = [
        {
          retentionPeriod = 14
          storageClass    = "GLACIER"
        }
      ]
      tagsMap {
        key = "value"
      }
    }
  }

  enableAll               = true
  metaStoreManagerRoleArn = "string"
  regions                 = ["us-east-1"]
}


resource "aws_security_lake_aws_log_source" "example" {
  enableAllDimensions = {
    string = {
      string = ["string"]
    }
  }
  enableSingleDimension = ["string"]
  enableTwoDimensions = {
    string = ["string"]
  }
  inputOrder = ["string"]
}

resource "aws_security_lake_subscriber" "example" {
  accessTypes = ["LAKEFORMATION"]
  accountId   = "1234567890"
  externalId  = "1234567890"
  sourceTypes = [
    {
      awsSourceType    = "string"
      customSourceType = "string"
    }
  ]
  subscriberDescription = "string"
  subscriberName        = "string"
}

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/securitylake
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateDatalake.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriber.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateAwsLogSource.html
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateCustomLogSource.html

Would you like to implement a fix?

Yes

@schuylr schuylr added the needs-triage Waiting for first response or review from a maintainer. label Feb 13, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added new-resource Introduces a new resource. new-data-source Introduces a new data source. new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2023
@aristosvo
Copy link
Contributor

I am interested in contributing, but as this would be my first issue on the AWS provider this might take a bit longer.

I have a bit of experience with azurerm though.

@AdamTylerLynch
Copy link
Collaborator

I am interested in contributing, but as this would be my first issue on the AWS provider this might take a bit longer.

I have a bit of experience with azurerm though.

@aristosvo AWS published a workshop on contributing to the AWS provider, I would suggest you start there as a learning path.
https://catalog.workshops.aws/contributing-to-the-terraform-provider

@markoskandylis
Copy link
Contributor

I will start working on this resource @aristosvo did you already made any progress? We can always collaborate :)

@aristosvo
Copy link
Contributor

Take it away, didn't have the time in the end. Will watch your MR to learn :)

@luescher-aws
Copy link

Happy to help contribute, I am a SME for Amazon Security Lake.

@markoskandylis
Copy link
Contributor

Thats great @luescher-aws please ping me internally to connect @mkandyli

@pfrederiksen
Copy link

Also happy to help if you want to connect internally.

@meetreks
Copy link
Contributor

@luescher-aws anyone picked up the log configuration? If not happy to wrap that up, had a look and looks pretty straightforward.

@markoskandylis
Copy link
Contributor

Hi @meetreks i am already working on that @luescher-aws you can work on custom logs if you want to pick something

@meetreks
Copy link
Contributor

@markoskandylis shall i pick create subscriber then?

@markoskandylis
Copy link
Contributor

@meetreks yes that sounds great 🙂

@gramsa49
Copy link
Contributor

gramsa49 commented Jan 5, 2024

I wanted to see if progress is being made on aws log sources. I can pick that up if your work has stalled.

@markoskandylis
Copy link
Contributor

Hi @gramsa49 aws log sources is now merged but you can take custom log sources if you want

@markoskandylis
Copy link
Contributor

Hi i will stat the work for custom log source

@kamalika-majumder
Copy link

Anyone working on the securitylake subscriber resources ?

@luescher-aws
Copy link

luescher-aws commented Feb 12, 2024 via email

@markoskandylis
Copy link
Contributor

Hi @kamalika-majumder currently i am working on it

@kamalika-majumder
Copy link

kamalika-majumder commented Feb 13, 2024

Oh great. @markoskandylis Any idea which release its going to be added next ?

@markoskandylis
Copy link
Contributor

@kamalika-majumder i will aim for the 29th release hopefully a bit faster if posible

@github-actions github-actions bot added this to the v5.40.0 milestone Mar 6, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kclinden
Copy link

Are there any plans to add a resource for managing Org configurations via following:

  • Action - CreateDataLakeOrganizationConfiguration
  • Action - GetDataLakeOrganizationConfiguration
  • Action - DeleteDataLakeOrganizationConfiguration
  • DataType - DataLakeAutoEnableNewAccountConfiguration

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. new-resource Introduces a new resource. new-service Introduces a new service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.