Skip to content

Commit

Permalink
Merge pull request #39871 from itd-seb/b-missing_transfer_sercurity_p…
Browse files Browse the repository at this point in the history
…olicy

Add missing transfer server security policy TransferSecurityPolicy-Restricted-2024-06
  • Loading branch information
ewbankkit authored Oct 25, 2024
2 parents daf26b1 + e2f4811 commit 97f91bb
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/39871.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_transfer_server: Add `TransferSecurityPolicy-Restricted-2024-06` as a valid value for `security_policy_name`
```
2 changes: 2 additions & 0 deletions internal/service/transfer/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,7 @@ const (
securityPolicyNamePQ_SSH_FIPS_2023_04 securityPolicyName = "TransferSecurityPolicy-PQ-SSH-FIPS-Experimental-2023-04"
securityPolicyNameRestricted_2018_11 securityPolicyName = "TransferSecurityPolicy-Restricted-2018-11"
securityPolicyNameRestricted_2020_06 securityPolicyName = "TransferSecurityPolicy-Restricted-2020-06"
securityPolicyNameRestricted_2024_06 securityPolicyName = "TransferSecurityPolicy-Restricted-2024-06"
)

func (securityPolicyName) Values() []securityPolicyName {
Expand All @@ -1274,5 +1275,6 @@ func (securityPolicyName) Values() []securityPolicyName {
securityPolicyNamePQ_SSH_FIPS_2023_04,
securityPolicyNameRestricted_2018_11,
securityPolicyNameRestricted_2020_06,
securityPolicyNameRestricted_2024_06,
}
}
9 changes: 9 additions & 0 deletions internal/service/transfer/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,15 @@ func testAccServer_securityPolicy(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "security_policy_name", "TransferSecurityPolicy-Restricted-2020-06"),
),
},
/*
{
Config: testAccServerConfig_securityPolicy(rName, "TransferSecurityPolicy-Restricted-2024-06"),
Check: resource.ComposeTestCheckFunc(
testAccCheckServerExists(ctx, resourceName, &conf),
resource.TestCheckResourceAttr(resourceName, "security_policy_name", "TransferSecurityPolicy-Restricted-2024-06"),
),
},
*/
},
})
}
Expand Down
1 change: 1 addition & 0 deletions website/docs/r/transfer_server.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ This resource supports the following arguments:
* `TransferSecurityPolicy-PQ-SSH-FIPS-Experimental-2023-04`
* `TransferSecurityPolicy-Restricted-2018-11`
* `TransferSecurityPolicy-Restricted-2020-06`
* `TransferSecurityPolicy-Restricted-2024-06`

See [Security policies for AWS Transfer Family servers](https://docs.aws.amazon.com/transfer/latest/userguide/security-policies.html) for details.
* `structured_log_destinations` - (Optional) A set of ARNs of destinations that will receive structured logs from the transfer server such as CloudWatch Log Group ARNs. If provided this enables the transfer server to emit structured logs to the specified locations.
Expand Down

0 comments on commit 97f91bb

Please sign in to comment.