-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
resource/aws_eks_node_group: Ensure testing and documentation include…
…s necessary IAM Role permissions depends_on configuration (#11010) Closes #10934 Reference: ENIs currently stuck in-use in main testing account us-west-2 Reference: #5904 Reference: #4426 Otherwise, EC2 ENIs managed by EKS can be left dangling on destroy. In the future, we can help reduce the need for explicit Terraform dependencies such as these via supporting the management of attached IAM Role policies directly in the aws_iam_role resource (e.g. #5904). Output from acceptance testing: ``` --- PASS: TestAccAWSEksNodeGroup_Version (1449.66s) --- PASS: TestAccAWSEksNodeGroup_AmiType (1462.03s) --- PASS: TestAccAWSEksNodeGroup_DiskSize (1510.26s) --- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (1575.37s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1584.41s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1597.61s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1624.95s) --- PASS: TestAccAWSEksNodeGroup_basic (1644.52s) --- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1646.77s) --- PASS: TestAccAWSEksNodeGroup_disappears (1652.94s) --- PASS: TestAccAWSEksNodeGroup_Labels (1655.54s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1702.82s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1764.88s) --- PASS: TestAccAWSEksNodeGroup_Tags (1768.71s) ```
- Loading branch information
Showing
2 changed files
with
80 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters