Initial work on Query command for List Resource #531
Conversation
|
|
||
| r.UnitTest(t, r.TestCase{ | ||
| TerraformVersionChecks: []tfversion.TerraformVersionCheck{ | ||
| tfversion.SkipBelow(tfversion.Version1_14_0), // Query mode requires Terraform 1.13.0 or later |
There was a problem hiding this comment.
Can we remove this comment since it contradicts what's in the code
| tfversion.SkipBelow(tfversion.Version1_14_0), // Query mode requires Terraform 1.13.0 or later | |
| tfversion.SkipBelow(tfversion.Version1_14_0), |
|
|
||
| for _, file := range fi { | ||
| if file.Mode().IsRegular() { | ||
| if filepath.Ext(file.Name()) == ".warioform" || filepath.Ext(file.Name()) == ".json" || filepath.Ext(file.Name()) == ".hcl" { |
There was a problem hiding this comment.
Do you think it makes sense to be more specific with the file extension here as well, also
.warioform
😬
| if filepath.Ext(file.Name()) == ".warioform" || filepath.Ext(file.Name()) == ".json" || filepath.Ext(file.Name()) == ".hcl" { | |
| if filepath.Ext(file.Name()) == ".warioform" || filepath.Ext(file.Name()) == ".json" || filepath.Ext(file.Name()) == ".tfquery.hcl" { |
| "github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/provider" | ||
| "github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/resource" | ||
| ) | ||
|
|
||
| var _ tfprotov6.ProviderServer = ProviderServer{} | ||
|
|
||
| // var _ tfprotov6.ProviderServerWithListResource = ProviderServer{} |
There was a problem hiding this comment.
Should this still be commented out?
There was a problem hiding this comment.
Generally speaking, this interface should only be directly referenced by exported terraform-plugin-go packages or testing packages like in terraform-plugin-mux
Since it's a temporary interface, we will eventually remove it once all downstream provider servers have a chance to implement them (for example, SDKv2 will need to implement the interface eventually, even if it doesn't have an SDK for the RPCs). Once that is removed, since there are no direct references to the interface itself, no downstream packages need to be re-released with the interface removed and provider's CI won't break 🙂
| @@ -71,6 +71,10 @@ func (c configurationFile) HasTerraformBlock(ctx context.Context) (bool, error) | |||
| return contains, nil | |||
| } | |||
|
|
|||
| func (c configurationFile) WriteQuery(ctx context.Context, dest string) error { | |||
| panic("WriteQuery not supported for configurationDirectory") | |||
There was a problem hiding this comment.
| panic("WriteQuery not supported for configurationDirectory") | |
| panic("WriteQuery not supported for configurationFile") |
Related Issue
Building off #528
Description
Adding ListResource and ValidateListResourceConfig from List Resource to plugin testing.
Rollback Plan
Changes to Security Controls
No