-
Notifications
You must be signed in to change notification settings - Fork 16
helper/resource: compatibility refresh after config mode test step #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
afae042
efd3234
3389c55
f639d90
a38c9fd
46efbf2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Copyright (c) HashiCorp, Inc. | ||
// SPDX-License-Identifier: MPL-2.0 | ||
|
||
package resource | ||
|
||
// Deprecated. This is an undocumented compatibility flag. When | ||
// `RefreshAfterApply` is set to non-empty, a `Config`-mode test step will | ||
// invoke a refresh before successful completion. This is intended as a | ||
// compatibility measure for test cases that have different -- but | ||
// semantically-equal -- state representations in their test steps. When | ||
// comparing two states, the testing framework is not aware of semantic | ||
// equality or set equality, as that would rely on provider logic. | ||
var RefreshAfterApply string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This acts as a build-time feature flag. The thought is that you'd add this as an
The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally I'd lean toward an environment variable, just being consistent with existing configuration options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about the flexibility to remove this flag some day. There is no timetable or specific urgency for that. If we get feedback that this flag is super effective & we do not come up with a better alternative in the future, then I have no desire to break it 😃