all: Remove temporary ProviderServerWithResourceIdentity interface
#516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
added
the
breaking-change
|
I'm gonna fix corner and the other repos before merging this, since they all have that problem (as does plugin-testing's go server) |
austinvalle
changed the title
ProviderServerWithResourceIdentity interface
This was referenced May 21, 2025
austinvalle
commented
May 21, 2025
austinvalle
commented
May 21, 2025
austinvalle
commented
May 21, 2025
SBGoods
previously approved these changes
May 21, 2025
SBGoods
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #478
Description
This PR removes the
ProviderServerWithResourceIdentitytemporary interface, which was causing issues with providers not implementing it fully via muxed providers or when implementing a plugin-go server, since Terraform v1.12.1 will callGetResourceIdentitySchemaseven if the provider doesn't support identity (GRPC unimplemented codes keep older providers from failing)Rollback Plan
Changes to Security Controls
N/A