-
Notifications
You must be signed in to change notification settings - Fork 35
tfprotov5+tfprotov6: Update to protocol versions 5.4/6.4 with GetMetadata RPC and GetProviderSchemaOptional server capability #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26e2027 to
88d4ba1
Compare
d8073a4 to
31d1908
Compare
austinvalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bendbennett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #310
The CI failures for terraform-provider-corner are expected in this case. Protocol upgrades that impose new RPCs will either require:
tfprotov5.ProviderServer/tfprotov6.ProviderServerinterface to require a new methodProviderServerWithGetMetadatain this case)terraform-plugin-go is a low level abstraction which is designed to directly implement the protocol rather than introduce its own abstractions. Most provider developers will directly interface with higher level Go modules, such as terraform-plugin-sdk and terraform-plugin-framework. Except for advanced provider development using this Go module directly, this type of low level "breaking" change will be hidden by also upgrading those Go modules at the same time:
GetProviderSchemaOptionalserver capability terraform-plugin-sdk#1235GetProviderSchemaOptionalserver capability terraform-plugin-framework#829Therefore the change is implemented on the existing interface. terraform-provider-corner happens to also implement its own terraform-plugin-go based provider server code, which is affected by this change. Upgrading the various dependencies and implementing the new method makes terraform-provider-corner testing successful, which can be seen with hashicorp/terraform-provider-corner#174. The CI of this Go module and terraform-provider-corner implementation details just happens to be a chicken-and-egg problem which tends to only come up in this particular type of functionality change. 🐔 🥚