Skip to content

Null check, better violation msgs, and added function descriptions #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Null check, better violation msgs, and added function descriptions #272

merged 4 commits into from
Feb 25, 2021

Conversation

ja5onhughe5
Copy link
Contributor

  • Created better violation messages
  • Added a null check for aws_security_group_rule loop
  • Updated test mocks for the null check
  • Cleaned up the loop for aws_security_group
  • Added function descriptions for tfplan docs

I added a null check in the aws_security_group_rule loop and additional info in the fail messaging.
Documentation on the new functions.
Added testing for the null values in the aws_security_group_rule loop. Moved the function docs to the right folder.
Copy link
Contributor

@rberlind rberlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ja5onhughe5 . Thanks for adding the new MD files.
One note: you don't need to add extra spaces and end of strings given in double quotes in the print() function when combining multiple with commas. For instance, `print("Roger", "Berlind") will print "Roger Berlind" since the print() function adds a space. But you don't have to change what you have.

@rberlind rberlind merged commit 2356bd2 into hashicorp:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants