Skip to content

add test to reproduce issue with signal: broken pipe on graceful shutdown #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dastrobu
Copy link

Related Issue

Relates to:

Description

This is a test to show the issue with signal: broken pipe on graceful shutdown, introduced by #512.
The PR only contains a test and no fix yet, as requested per comment from @radeksimko.

The unit test TestGracefulCancellation_interruption_on_apply usually fails with:

expected interrupt signal, received "signal: broken pipe"

Although sometimes I have also seen:

expected interrupt signal, received "exit status 255"

It seems to depend on timing.

In our production code, we would love to see graceful shutdown being handled correctly, as intended by #512.
However, we are observing signal: broken pipe and a locked Terraform state, which is what we would like to get rid of to avoid the need to manually unlock the state again.

I can try to provide a fix as well if there is some guidance on how to do it.

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@dastrobu dastrobu requested review from a team as code owners May 21, 2025 09:21
Copy link

hashicorp-cla-app bot commented May 21, 2025

CLA assistant check
All committers have signed the CLA.

@dastrobu dastrobu force-pushed the test/expected-interrupt-signal,-received-signal-broken-pipe branch 2 times, most recently from 728e132 to 127f408 Compare May 21, 2025 09:33
@dastrobu dastrobu force-pushed the test/expected-interrupt-signal,-received-signal-broken-pipe branch from 127f408 to 0b6b493 Compare May 21, 2025 09:34
@radeksimko
Copy link
Member

@dastrobu This looks quite promising. I'll look into this in more detail when I get a moment. Thanks a lot for sharing this test case.

@radeksimko radeksimko self-assigned this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants