-
Notifications
You must be signed in to change notification settings - Fork 139
Add notification banner to docs #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c961057
to
448ef03
Compare
@rmainwork I'm assuming this will render differently when live? It looks like this in the preview: For the language, suggest rewording to something like: Documentation Update: HCP Terraform documentation is now in the Edited for brevity and to let folks know the "Edit on Github" button still works. |
I don't think we need this alert. I think this is adding a lot of content management overhead and taking up valuable page real estate when the move should be mostly invisible to all but hardcore contributors.
If we decide to keep it, can we use a partial so it's easier to tweak if necessary? |
@rkoron007 @trujillo-adam this is something we've typically done with other migrated repos after a content sync between the doc repo and UDR . It's primary purpose is notify anyone making changes to the doc said changes won't have any effect and their changes should instead should be made in UDR. Since it would merged after the content sync - it wouldn't show up in dev portal. |
just jumping in here - confirming this alert will not be rendered in Developer, it's only if users are looking in github itself which is why we're explicitly calling out where to make edits. since this isn't rendered on Developer, I think we'll still move forward with this to keep consistency with other repos, but @rkoron007 @trujillo-adam let us know if you feel strongly against that! thanks for the feedback 🙏 |
80f8b26
to
fd09ac1
Compare
fd09ac1
to
f828a80
Compare
As-per the discussion in the Terraform launch meeting - I've gone ahead and added emojis to the banner comment for consistency with hashicorp/terraform#37175 |
All good, thanks! I did not realize that these notices will not appear on the website or in the new repo. |
Just want to also call out here that changes from this repo (prior to the banner addition) were re-synced to UDR in hashicorp/web-unified-docs#461 |
This (temporarily) reverts PR #916
What
Add notification banner to re-direct contributors to UDR
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
website/redirects.js
for moved, renamed, or deleted pages. (N/A)Reviews