-
Notifications
You must be signed in to change notification settings - Fork 471
feat!: update minimum required Node.js version to 20.19 #3888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use node 22 as minimum? I found a minimum with a minor version often frustrating as a user in the past.
@DanielMSchmidt Among other things, there's no Node 22 runner for GitHub Actions yet, so anyone trying to use this in a GHA context (without Docker) is going to have issues if we require Node 22 as minimum. I agree with using Node 20 here, but my personal take has always been to use the lowest value that's considered LTS which is |
I didn't realize that there were specific minor versions that were LTS. Where did you get this information? I just went for the latest minor version available, but that's useful to know |
I think I got it. That's the release they marked it as LTS on their blog. |
Description
Since Nodejs 18 is no longer LTS, we're bumping the minimum version required for CDKTF to Node 20
Checklist