Skip to content

feat!: update minimum required Node.js version to 20.19 #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mutahhir
Copy link
Member

Description

Since Nodejs 18 is no longer LTS, we're bumping the minimum version required for CDKTF to Node 20

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested review from a team as code owners May 28, 2025 13:39
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team May 28, 2025 13:39
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use node 22 as minimum? I found a minimum with a minor version often frustrating as a user in the past.

@xiehan
Copy link
Member

xiehan commented May 28, 2025

@DanielMSchmidt Among other things, there's no Node 22 runner for GitHub Actions yet, so anyone trying to use this in a GHA context (without Docker) is going to have issues if we require Node 22 as minimum.

I agree with using Node 20 here, but my personal take has always been to use the lowest value that's considered LTS which is 20.9.0 in this case, otherwise some folks are still going to run into compatibility issues.

@mutahhir
Copy link
Member Author

I agree with using Node 20 here, but my personal take has always been to use the lowest value that's considered LTS which is 20.9.0 in this case, otherwise some folks are still going to run into compatibility issues.

I didn't realize that there were specific minor versions that were LTS. Where did you get this information? I just went for the latest minor version available, but that's useful to know

@mutahhir
Copy link
Member Author

I think I got it. That's the release they marked it as LTS on their blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants