-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utilize .tool-versions file to resolve terraform version #323
Open
plukevdh
wants to merge
8
commits into
hashicorp:main
Choose a base branch
from
plukevdh:use-tool-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
approved these changes
Nov 8, 2023
cc @austinvalle |
up, it would be very helpful |
Hello? |
chenrui333
approved these changes
Jun 12, 2024
I am not maintainer for the repo, but this looks good to me :) |
Ah sorry about that @chenrui333. Saw you had an early review and thought you might be someone who could move this along. Appreciate the eyes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several other Github Actions are utilizing the ASDF
.tool-versions
file for controlling... well... tool versions.This is super rudimentary, but since
.tool-versions
is a fairly straightforward formatting option (i.e., only X.Y.Z), it seems fairly easy to add on as a potential version resolution option.Would love feedback and modifications as this is found useful.