[IND-4227][COMPLIANCE] chore: update build tags to modern format #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced all deprecated `// +build` directives with the modern `//go:build` form introduced in Go 1.17. This modernizes build constraints to align with the latest Go toolchain and removes obsolete syntax flagged by go vet linter. - No runtime or functional behavior changes.⚠️ Note: This change drops compatibility with Go versions earlier than 1.17, as they do not support the `//go:build` syntax.
|
The CI lint is failing for this one. Can you please address that as well. |
Contributor
Author
@ritikrajdev I've added golangci-lint migrate changes and the CI checks are now passing, plz check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced all deprecated
// +builddirectives with the modern//go:buildform introduced in Go 1.17. This modernizes build constraints to align with the latest Go toolchain and removes obsolete syntax flagged by go vet linter.No runtime or functional behavior changes.
//go:buildsyntax.Related Issue
This change is required to fix lint issues that appeared during CI checks in #780 .
How Has This Been Tested?
golangci-lint cache clean && golangci-lint run ./...succeeded with zero issues after migratinggolangci-lintconfig to the latest version in local (Migration guide).golangci-lintCI check would still fail until the above said migration is not complete.Local testing steps:
exclude_godoc_examples: falseline in.golangci.ymlfile.golangci-lint migratecommand to migrate golangci-lint config to the latest supported version.golangci-lint cache clean && golangci-lint run ./...