Skip to content

Conversation

@mbver
Copy link

@mbver mbver commented Aug 20, 2024

  • lastEvents and latestEvents are easily confused with one another. recommend using newEvents. coalesceEvent is not descriptive of its role. it is event for a node, so call it nodeEvent.
  • using only event types for lastEvents is too clever and make the code harder to reason about. furthermore, it doesn't help in checking duplicating member-update-event. stick with nodeEvent for lastEvents and it handles duplication with ease.

@mbver mbver requested a review from a team as a code owner August 20, 2024 14:22
@mbver mbver requested review from banks and removed request for a team August 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant