Set last contact on leader step down #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -792,6 +799,11 @@ func (r *Raft) runLeader() { | |||
| select { | |||
| case notify <- false: | |||
| case <-r.shutdownCh: | |||
| // On shutdown, make a best effort but do not block | |||
There was a problem hiding this comment.
Is this related to the last contact change or something else?
There was a problem hiding this comment.
Its a race condition in one of the unit tests, basically during a shutdown we may fail to push to notify channel, so this tries to fix it without blocking.
|
@armon noted two small comments, otherwise looks good. Took a few CI pokes to get things to pass (especially with the ancient Go version) but I don't think those failures were related to your change. |
|
Looks good to me. |
armon
added a commit
that referenced
this pull request
Jan 22, 2016
Set last contact on leader step down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the leader steps down, its last contact time will be from when it was last contacted as a follower, which may be either zero or a very long time ago. This fix updates the last contact time to when we stepped down, better reflecting the recency of the data.