Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to pass in their own logger. #35

Merged
merged 1 commit into from
Jan 25, 2015
Merged

Conversation

stapelberg
Copy link
Contributor

For making raft log to github.com/golang/glog, it is necessary to
specify a custom logger, because glog expects you to set the Lshortfile
flag.

Aside from this specific example, I think in general it’s better to give
users more control over the logger instead of creating it for the user —
after all, it’s still just a single line of code.

For making raft log to github.com/golang/glog, it is necessary to
specify a custom logger, because glog expects you to set the Lshortfile
flag.

Aside from this specific example, I think in general it’s better to give
users more control over the logger instead of creating it for the user —
after all, it’s still just a single line of code.
armon added a commit that referenced this pull request Jan 25, 2015
Allow users to pass in their own logger.
@armon armon merged commit e59cced into hashicorp:master Jan 25, 2015
@armon
Copy link
Member

armon commented Jan 25, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants