Skip to content

Fixed undefined error with respect to the S3 policies #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed undefined error with respect to the S3 policies #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions policies/s3/s3-enable-object-logging-for-events.sentinel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ referenced_s3_bucket_names = []
references_all_s3_buckets = false
for cloudtrail_resources as _, res {
event_selector_block = res[const.values][const.event_selector_block]
if event_selector_block is empty {
if event_selector_block is empty or event_selector_block is not defined {
continue
}

Expand All @@ -56,7 +56,7 @@ for cloudtrail_resources as _, res {
es[const.read_write_type] is event_type {

for es[const.data_resource] as _, data_res {
if data_res[const.type] is not const.aws_s3_object {
if data_res[const.type] is not const.aws_s3_object or data_res[const.values] is not defined {
continue
}

Expand Down
9 changes: 7 additions & 2 deletions policies/s3/s3-require-mfa-delete.sentinel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,13 @@ check_mfa_from_const = func(config) {
}

is_mfa_enabled = func(res) {
return collection.find(res.config.versioning_configuration, func(config) {
return config.status.constant_value is const.enabled and
return collection.find(maps.get(res.config, "versioning_configuration", []), func(config) {
status = maps.get(config, "status", "")
if status is empty {
return false
}

return status.constant_value is const.enabled and
config[const.mfa_delete] is defined and
(check_mfa_from_const(config) or check_mfa_from_refrence_var(config))
}) is defined
Expand Down