Allow Powershell provisioner to use service accounts #6972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice one ! Thanks. |
Contributor
Author
|
Ok, I'll try and get that fixed up. |
Contributor
Author
|
Tests seem happy now. |
azr
reviewed
Nov 9, 2018
SwampDragons
approved these changes
Nov 12, 2018
Contributor
SwampDragons
left a comment
SwampDragons
left a comment
There was a problem hiding this comment.
Awesome!! Thanks for this :D
obilodeau
added a commit
to GoSecure/malboxes
that referenced
this pull request
Sep 4, 2019
Turns out that the upstream feature was introduced in 1.3.3 released on December 5, 2018 and merged in hashicorp/packer#6972.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the logic defined in #6104 to allow running Powershell with a service account, i.e. setting
elevated_passwordto an empty value.Tested using a Powershell script that runs Puppet with
elevated_userset toSYSTEM. Previously Puppet didn't have sufficient permissions within the WinRM connection to install all packages/apply changes whereas now it seems to work properly. Ultimately I'd like to extract some of this elevated functionality to fix #5478 (except with thepuppet-serverprovisioner instead) however my familiarity with Windows internals is a tad lacking currently.Fixes #6104