Conversation
Contributor
Author
|
I wish there was a better way to alert people that an option has been deprecated. Like maybe if we could check each fixer and let the user know if a template is fixable... |
Contributor
|
Maybe just add a return value from the fixer interface which tells if the template was fixed and run through them before validate and output a message and the fixer synopsis if one must be applied. |
adds fixer removes documentation removes from docker builder and docker-push pp
Contributor
Author
|
created #5513 for fix check during validation |
SwampDragons
approved these changes
Oct 25, 2017
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds fixer
removes documentation
removes from docker builder and docker-push pp
Fixes #5507