Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external plugins to latest available release #11761

Merged
merged 1 commit into from
May 20, 2022
Merged

Update external plugins to latest available release #11761

merged 1 commit into from
May 20, 2022

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented May 5, 2022 •
edited
Loading

This change is to pull in the latest version of all bundled plugins that have been patched with the SSH legacy key algorithm fix.

  • Pull updated plugin for Amazon
  • Pull updated plugin for Azure
  • Pull updated plugin for GCP
  • Possibly all plugins to bring them all up to date.

Related to #8609
Related to #10074
Related to #11656

@nywilken nywilken requested a review from a team as a code owner May 5, 2022 16:04
@nywilken nywilken changed the base branch from main to nywilken/update-plugin-sdk May 5, 2022 16:06
Base automatically changed from nywilken/update-plugin-sdk to main May 5, 2022 17:35
This was referenced May 5, 2022
Closed
Closed
Closed
@nywilken nywilken force-pushed the nywilken/update-external-plugins branch from b8252c4 to edc8a4d Compare May 5, 2022 19:44
@jpbuecken
Copy link

jpbuecken commented May 6, 2022 •
edited
Loading

Not sure if this is the correct place, but to the context:
-> Possibly all plugins to bring them all up to date.
I need it for the vsphere-iso builder
(Use-Case: I build CentOS 9 stream with kickstart, and add a ssh public key via kickstart file, that packer uses to connect later)

EDIT: Replaced vmware-iso with vsphere-iso.

@sylviamoss
Copy link
Contributor

@nywilken @jpbuecken I released vpshere v1.0.4 and bumped the plugin in this PR.

@nywilken nywilken force-pushed the nywilken/update-external-plugins branch from f24d312 to 9bf17ec Compare May 19, 2022 20:21
JenGoldstrich
JenGoldstrich approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JenGoldstrich JenGoldstrich merged commit 177ea5f into main May 20, 2022
@JenGoldstrich JenGoldstrich deleted the nywilken/update-external-plugins branch May 20, 2022 14:58
@sbraz
Copy link

sbraz commented May 25, 2022

Hi @nywilken, this seems to be missing the changes made in hashicorp/packer-plugin-openstack#60. Would it please be possible to include the fix for the OpenStack plugin too?

@nywilken
Copy link
Contributor Author

Hi @nywilken, this seems to be missing the changes made in hashicorp/packer-plugin-openstack#60. Would it please be possible to include the fix for the OpenStack plugin too?

Hi @sbraz I made the call to merge in the changes we had so that the released plugins could be part of the nightly. We released all other plugins today; including openstack. I'll get all the plugins updated and trigger a nightly. I anticipate making a Packer release this week. But until then you can you try out the nightly . Thanks for pinging the thread.

nywilken added a commit that referenced this pull request May 25, 2022
@nywilken
Bump versions for all recently plugins
1867bd8 
This change brings all plugins in Packer core up to date to address
issues with legacy SSH RSA-SHA1 key algorithms.

Related to: #11761
@nywilken nywilken mentioned this pull request May 25, 2022
Merged
nywilken added a commit that referenced this pull request May 25, 2022
@nywilken
Bump versions for all recently plugins
aaeba32 
This change brings all plugins in Packer core up to date to address
issues with legacy SSH RSA-SHA1 key algorithms.

Related to: #11761
nywilken pushed a commit that referenced this pull request May 25, 2022
Bump versions for all recently plugins (#11802)
6f1cefa 
* Bump versions for all recently plugins

This change brings all plugins in Packer core up to date to address
issues with legacy SSH RSA-SHA1 key algorithms.

Related to: #11761

* Update repository for packer-plugin-outscale
@al-cheb al-cheb mentioned this pull request May 31, 2022
Merged
4 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nywilken @jpbuecken @sylviamoss @sbraz @JenGoldstrich