Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add copy button for client/allocation UUIDs #5926

Merged
merged 28 commits into from
Jul 15, 2019
Merged

UI: Add copy button for client/allocation UUIDs #5926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e671478
Add Structure icons
backspace Jul 4, 2019
fbf729d
Add ember-cli-clipboard
backspace Jul 4, 2019
40dcfe2
Add qunit-dom
backspace Jul 4, 2019
e92b316
Add prototype copy button for client UUID
backspace Jul 4, 2019
398daec
Add hackish styling
backspace Jul 4, 2019
935c577
Add auto-reset after success
backspace Jul 5, 2019
042cf83
Fix size of success “button”
backspace Jul 5, 2019
8611562
Add copy button for allocation id
backspace Jul 5, 2019
190a20a
Move class name into component
backspace Jul 5, 2019
11afd99
Add always-showing success tooltip
backspace Jul 5, 2019
5b532ba
Change button to only hide when asked to
backspace Jul 5, 2019
827d086
Add button wrapper for error icon
backspace Jul 8, 2019
e584232
Change success/error “button”s to be static
backspace Jul 8, 2019
fb8e716
Move copy button up slightly
backspace Jul 8, 2019
4b08c30
Remove show-on-hover functionality
backspace Jul 8, 2019
b2d9e0c
Add default state
backspace Jul 8, 2019
a28e9de
Add tooltip for copy error
backspace Jul 8, 2019
fe30164
Rename component
backspace Jul 8, 2019
a1dd378
Move copy-button styling into its own file
backspace Jul 8, 2019
5270bec
Add copy button to styleguide
backspace Jul 8, 2019
9475188
Rename missed file
backspace Jul 8, 2019
3d46b61
Add another default property
backspace Jul 8, 2019
9180fbe
Add explanation of re-export
backspace Jul 8, 2019
a826034
Remove outdated FIXME
backspace Jul 8, 2019
f9f405c
Remove trailing newline
backspace Jul 8, 2019
5e302ee
Add changelog entry
backspace Jul 8, 2019
e8a1ae0
Convert success action to task
backspace Jul 15, 2019
5db4a87
Remove run.later in favour of timeout
backspace Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change success/error “button”s to be static
  • Loading branch information
@backspace
backspace committed Jul 8, 2019
commit e584232e320c76ebd0c13348195c01492845e818
4 changes: 4 additions & 0 deletions ui/app/styles/core/buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@ $button-box-shadow-standard: 0 2px 0 0 rgba($grey, 0.2);
.button {
color: inherit;

&.is-static {
background-color: inherit;
}

svg {
fill: currentColor;
}
Expand Down
4 changes: 2 additions & 2 deletions ui/app/templates/components/x-copy-button.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{{! FIXME copy-button is taken by ember-cli-clipboard, but… 🤔 }}
{{#if (eq state 'success')}}
<div class='button is-borderless is-small'>
<div class='button is-borderless is-small is-static'>
<span class="tooltip text-center always-active" role="tooltip" aria-label="Copied!">
{{x-icon 'copy-success'}}
</span>
</div>
{{else if (eq state 'error')}}
<div class='button is-borderless is-small'>
<div class='button is-borderless is-small is-static'>
{{x-icon 'alert-triangle'}}
</div>
{{else}}
Expand Down