Unset CGO_ENABLED for ARM builds #5337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nomad 0.9 uses libcontainer which requires cgo. Have you tested the |
|
@schmichael youre correct, this fails on 0.9+ |
|
Sad. Thanks for working on this and testing @myoung34 ! |
bltavares
added a commit
to bltavares/nomad-arm6l
that referenced
this pull request
Apr 7, 2019
This commit provides a cross compilation Docker image which compiles the project using the same scripts as it is used on the remote machine. With the cross compilation image it is possible to test it locally. We introduced a new compiler on the build step, so we are capable of using `cgo` during compilation, as it was [reported] to be required for newer versions of Nomad. This has been tested running Docker from Mac, and sending the output to a Pi Zero W using `scp`. The binary starts up, but there were no further tests on how the scheduler behaves at this moment. This also has been tested compiling Nomad `0.8.7` and `master` (currently `0.9.0-dev`), using the `CGO_ENABLED` and the correct gcc `armv6l` compiler. [reported]: hashicorp/nomad#5337
bltavares
added a commit
to bltavares/nomad-arm6l
that referenced
this pull request
Apr 7, 2019
This commit provides a cross compilation Docker image which compiles the project using the same scripts as it is used on the remote machine. With the cross compilation image it is possible to test it locally. We introduced a new compiler on the build step, so we are capable of using `cgo` during compilation, as it was [reported] to be required for newer versions of Nomad. This has been tested running Docker from Mac, and sending the output to a Pi Zero W using `scp`. The binary starts up, but there were no further tests on how the scheduler behaves at this moment. This also has been tested compiling Nomad `0.8.7` and `master` (currently `0.9.0-dev`), using the `CGO_ENABLED` and the correct gcc `armv6l` compiler. [reported]: hashicorp/nomad#5337
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2517