Skip to content

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Oct 21, 2023

Test the JWT auth flow using real Nomad and Vault agents.

Test the JWT auth flow using real Nomad and Vault agents.
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @lgfa29! It looks like there's a minor issue to mop-up with the changes in testutil, but LGTM once that's fixed.

@lgfa29
Copy link
Contributor Author

lgfa29 commented Oct 23, 2023

Ops, syncing Nomad an Vault log level sounded like a good idea when running it locally but I didn't realize that off was used in CI 😅

I capped the log level for Vault to error but also added another env var to allow setting a log level specific for Vault if necessary.

Copy link

github-actions bot commented Feb 7, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants