Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state: move variables tests to use must library. #17609

Merged
merged 1 commit into from
Jun 20, 2023
Merged

state: move variables tests to use must library. #17609

merged 1 commit into from
Jun 20, 2023

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jun 20, 2023

Small piece of admin while starting locking work.

@jrasell jrasell added the backport/1.5.x backport to 1.5.x release line label Jun 20, 2023
@jrasell jrasell requested review from shoenig, angrycub and tgross June 20, 2023 09:39
@jrasell jrasell self-assigned this Jun 20, 2023
tgross
tgross approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shoenig
shoenig approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some casts I don't think we need anymore

@jrasell jrasell force-pushed the jrasell-move-state-variables-tests-must branch from 897befa to 8884da2 Compare June 20, 2023 13:25
@jrasell jrasell force-pushed the jrasell-move-state-variables-tests-must branch from 8884da2 to 1bdba6b Compare June 20, 2023 13:26
@jrasell jrasell merged commit e4beb12 into main Jun 20, 2023
@jrasell jrasell deleted the jrasell-move-state-variables-tests-must branch June 20, 2023 14:46
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 20, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@tgross tgross tgross approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@jrasell jrasell

Labels
backport/1.5.x backport to 1.5.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasell @shoenig @tgross