hashicorp/go-msgpack v2 #16810
Merged
hashicorp/go-msgpack v2 #16810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op.
lgfa29
added
backport/1.3.x
lgfa29
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Thanks for the work here @IamTheFij!
I was catching-up on this change and it seems like the v2 tag was more of a way to help the Consul team manage its dependencies since they still use v0.5.5 directly and, without this tag, Go would pull v1.5.5 which does not work for them. Creating the v2 tag makes Go aware of this incompatibility.
I pushed a commit to pin our dependency on v2.0.0 instead of v2.1.0 though. v2.1.0 does have some code changes that we the Nomad team will have to evaluate before adopting it.
Using v2.0.0 is no-op for us, so I will keep it at that for now.
This was referenced Apr 17, 2023
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Ian Fijolek <ian@iamthefij.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Ian Fijolek <ian@iamthefij.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 17, 2023
* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0 Fixes #16808 * Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack * deps: use go-msgpack v2.0.0 go-msgpack v2.1.0 includes some code changes that we will need to investigate furthere to assess its impact on Nomad, so keeping this dependency on v2.0.0 for now since it's no-op. --------- Co-authored-by: Ian Fijolek <ian@iamthefij.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
May 1, 2023
lgfa29
added a commit
that referenced
this pull request
May 1, 2023
lgfa29
added a commit
that referenced
this pull request
May 1, 2023
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to v2 of both hashicorp/go-msgpack and hashicorp/net-rpc-msgpackrpc to resolve the dependency on a the retracted version, v1.1.5, of hashicorp/go-msgpack.
hashicorp/raft still depends on hashicorp/go-msgpack v0.5.5, which is now an indirect dependency.
Fixes #16808