-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: add namespace to nested detail pages #15261
Conversation
Ember Asset Size actionAs of ff5b68d Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @juliezzhou here, but I'm not in love with the formatting here. The misalignment feels like an error. Would it be better to display this in a single line and format it like the route/url does (i.e. "$job-ID@$namespace-ID")?
That's a great suggestion! I gave it a try just now... one challenge that I see with a single line is that we have to deal with a deeply nested view that goes 5-6 levels deep. In the event of a parameterized job, we'd have overflow. That's probably too much to work around right now considering we have a redesign coming around the corner. IMHO, the most swift solution that solves a user's problem and doesn't require too much work before the redesign, would be to just include the namespace as a smaller text below the name (and even consider just adding the Per the ticket, it sounds like user's are looking for a quick fix:
Would it be unreasonable to get a quick fix in now to resolve the issue, and then consider challenges we may face with balancing look & feel and maintaining a responsive design? |
Ember Test Audit comparison
|
My concern is if it is not called "namespace-1", but "apps" or "default", will it still be clear to the users that it means the namespace? |
@juliezzhou what would you propose a solution? The simplest solution I could see would be pattern matching what we do in the URL: Because it matches the pattern that we have in the URL, and the text is smaller that could be enough guidance for the user. |
We could also just use |
The community user filing the ticket mentioned the pain point was leaving a tab, coming back and wanting to take an action to "restart" (or take another action) on an allocation, but being unsure about the job. I'm unsure if changing the title of the Job Detail page solves the problem, because the user will still need to click back into the page. And re: the tooltip, that seems like an elegant solution but it still seems like a paper cut in the user experience because I think they just want to visually see which job they're on (jobs are unique by namespace and name). I think @juliezzhou's suggestion of smaller text with the |
Yeah, good call out on leaving the page @ChaiWithJai! While it doesn't have to be the breadcrumb, we do need something visually that is persistent across pages to contextualize the namespace. My preference given all of the conversation and options at this point is that we give Julie a little time to think through this problem. If we end up deciding we want to do this via the breadcrumb, we haven't lost any work. If we decide on a different solution, we will have done right by our users. If we go with a breadcrumb, I think I would still prefer the text on one line and the same size purely from a design perspective. Visually, having three different type sizes there looks a little inconsistent. |
Nice @wdmeest, that's a good suggestion too! And thanks for the original issue! We're doing a little exploration on our side and we'll definitely add this as an option to consider. We're going to do some design work to consider all possible options (both already considered and some not discussed yet) to figure out what might best solve this problem for you and other users. |
Josh is currently on vacation. Phil has approved the PR per directions from both Josh and Julie. So favoring getting this work in instead of having it linger.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes 15169
Add
namespace
to Allocation Details and Task Details on the respective overview pages.