ci: use groups of tests in gha #15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
approved these changes
Oct 24, 2022
Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Nov 3, 2022
* ci: backport of gha groups (#15058) * ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com> * build: fix makefile conflict Co-authored-by: Tim Gross <tgross@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hold until after 1.4.2)
This PR changes our
Core CI TestsGHA to run packages in groups of packages instead of one runner per package.The plumbing is a bit more complex, so it's now documented in
ci/README.md.Grouping packages this way dramatically cuts down on the number of runners invoked by each
pushevent. We were triggering ~50 concurrent runners; now we should use about 7. Packages are organized into groups as declared inci/test-core.json. The idea is to create groups that are reasonably well balanced in terms of run time. We can tweak the groups going forward as needed.The
tools/missingtool has been updated to scanci/test-core.jsonagainst Nomad source. It also now serves as a translator for group -> package list.In a followup PR we can probably have the
driversgroup run on all platforms, eliminating the need for the Circletest-windowsrunner.