-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Fix server list leader determination for IPv6 #10530
Conversation
This closes #10513, thanks to @bastelfreak for the report. GET /status/leader returns an IPv6 host with square brackets around the IP address as expected, but the rpcAddr property on the agent model does not. This fixes rpcAddr, updates the Mirage /status/leader mock to properly format an IPv6 host, and changes the agent factory to sometimes produce IPv6 addresses. I added a formatHost utility function to centralise the conditional square bracket-wrapping that would have otherwise been further scattered around.
Ember Asset Size actionAs of 1dadfc2 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
b890a1f
to
1dadfc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a rare bug that's as old as the UI!
The formatHost
util is great for tucking away this tiny bit of complexity.
@DingoEatingFuzz thanks for the merge and @backspace thanks for fixing it. Do you already know when the next release is plannend / are nightly binarys available with the fix? |
It didn’t make it into 1.1.0, sadly, so it’ll have to wait for 1.1.1, which is currently unscheduled. There aren’t nightlies 😞 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This closes #10513, thanks to @bastelfreak for the report.
GET /status/leader
returns an IPv6 host with square bracketsaround the IP address as expected, but the
rpcAddr
propertyon the agent model does not.
This fixes
rpcAddr
, updates the Mirage/status/leader
mockto properly format an IPv6 host, and changes the agent
factory to sometimes produce IPv6 addresses.
I added a
formatHost
utility function to centralise theconditional square bracket-wrapping that would have
otherwise been further scattered around.