Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix server list leader determination for IPv6 #10530

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

backspace
Copy link
Contributor

@backspace backspace commented May 6, 2021

This closes #10513, thanks to @bastelfreak for the report.
GET /status/leader returns an IPv6 host with square brackets
around the IP address as expected, but the rpcAddr property
on the agent model does not.

This fixes rpcAddr, updates the Mirage /status/leader mock
to properly format an IPv6 host, and changes the agent
factory to sometimes produce IPv6 addresses.

I added a formatHost utility function to centralise the
conditional square bracket-wrapping that would have
otherwise been further scattered around.

This closes #10513, thanks to @bastelfreak for the report.
GET /status/leader returns an IPv6 host with square brackets
around the IP address as expected, but the rpcAddr property
on the agent model does not.

This fixes rpcAddr, updates the Mirage /status/leader mock
to properly format an IPv6 host, and changes the agent
factory to sometimes produce IPv6 addresses.

I added a formatHost utility function to centralise the
conditional square bracket-wrapping that would have
otherwise been further scattered around.
@github-actions
Copy link

github-actions bot commented May 6, 2021

Ember Asset Size action

As of 1dadfc2

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +245 B +32 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented May 6, 2021

Ember Test Audit comparison

main 1dadfc2 change
passes 1079 1079 0
failures 0 0 0
flaky 0 0 0
duration 8m 45s 184ms 8m 03s 069ms -42s 115ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a rare bug that's as old as the UI!

The formatHost util is great for tucking away this tiny bit of complexity.

@backspace backspace merged commit a9ec864 into main May 13, 2021
@backspace backspace deleted the b-ui/leader-ipv6 branch May 13, 2021 17:29
@bastelfreak
Copy link

@DingoEatingFuzz thanks for the merge and @backspace thanks for fixing it. Do you already know when the next release is plannend / are nightly binarys available with the fix?

@backspace
Copy link
Contributor Author

It didn’t make it into 1.1.0, sadly, so it’ll have to wait for 1.1.1, which is currently unscheduled. There aren’t nightlies 😞

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad Server UI shows no elected leader; but CLI does
3 participants