Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arm64-compatible image for Consul API Gateway echo services #67

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Jun 10, 2022

Fixes #65

To test, just follow the Learn guide instructions for local/kind using this version of learn-consul-kubernetes.

Without this, the user may apply `two-services` with a non-default namespace context resulting in the ConfigMaps going to a different namespace from the other resources. In this case, nginx and product-api-db can't stand up successfully.
@@ -18,6 +18,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: nginx-config
namespace: default
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See explanation on 0cb4e3f

@nathancoleman nathancoleman marked this pull request as ready for review June 10, 2022 18:32
Copy link
Contributor

@mikemorris mikemorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this image a few weeks ago on an Intel-based Mac and it worked fine for me then.

Copy link
Contributor

@eddie-rowe eddie-rowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -
Reviewed the changes and they should have no effect on the tutorial.

@eddie-rowe eddie-rowe merged commit 7ec2a2a into main Jun 13, 2022
@eddie-rowe eddie-rowe deleted the arm64-echo branch June 13, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Echo images for Consul API Gateway are not arm64-compatible
3 participants