Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Stacks, StackPlans support #934

Merged

Conversation

brandonc
Copy link
Collaborator

I was unable to add meaningful tests yet but plan to backfill them later once the GAP on staging is able to execute stack operations once again.

@brandonc brandonc requested a review from a team as a code owner July 12, 2024 23:03
stack.go Outdated Show resolved Hide resolved
Comment on lines +101 to +108
type StackConfigurationStatusTimestamps struct {
QueuedAt *time.Time `jsonapi:"attr,queued-at,omitempty,rfc3339"`
CompletedAt *time.Time `jsonapi:"attr,completed-at,omitempty,rfc3339"`
PreparingAt *time.Time `jsonapi:"attr,preparing-at,omitempty,rfc3339"`
EnqueueingAt *time.Time `jsonapi:"attr,enqueueing-at,omitempty,rfc3339"`
CanceledAt *time.Time `jsonapi:"attr,canceled-at,omitempty,rfc3339"`
ErroredAt *time.Time `jsonapi:"attr,errored-at,omitempty,rfc3339"`
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the more constrained format rfc3339 and not iso8601?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all practical purposes, the API emits dates that fits both formats. For the purposes of parsing dates from HCP Terraform, they should be equivalent. RFC3339 is the slightly more stringent version so I usually choose it

sebasslash
sebasslash previously approved these changes Jul 18, 2024
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

stack.go Outdated Show resolved Hide resolved
stack_configuration.go Show resolved Hide resolved
stack_integration_test.go Outdated Show resolved Hide resolved
return
}

func TestStackConverged(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Uk1288
Uk1288 previously approved these changes Jul 18, 2024
@brandonc brandonc dismissed stale reviews from Uk1288 and sebasslash via 30cc1ac July 18, 2024 22:27
@brandonc brandonc merged commit cc4a306 into main Jul 19, 2024
7 checks passed
@brandonc brandonc deleted the TF-18387-stacks-configuration-deployment-support-in-go-tfe branch July 19, 2024 15:24
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants