Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPL-4359] refactor registry module delete API calls #847

Merged

Conversation

laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Feb 5, 2024

Description

The API calls to the registry module DELETE endpoint have been deprecated and replaced. See API docs. This PR adds new DELETE endpoints.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope my feedback makes sense. We can meet to discuss if you want.

registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
registry_module_integration_test.go Show resolved Hide resolved
registry_module_integration_test.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it should work. Just a little API and godoc feedback 👇

registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
registry_module.go Outdated Show resolved Hide resolved
@laurenolivia laurenolivia force-pushed the laurenolivia/refactor-registry-module-delete-endpoints branch from f13c174 to f663d70 Compare February 15, 2024 17:14
@laurenolivia laurenolivia force-pushed the laurenolivia/refactor-registry-module-delete-endpoints branch from f663d70 to 4f7320e Compare February 15, 2024 17:29
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a CHANGELOG entry

@laurenolivia laurenolivia merged commit 28d2be4 into main Feb 15, 2024
10 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/refactor-registry-module-delete-endpoints branch February 15, 2024 18:06
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

laurenolivia added a commit that referenced this pull request Feb 15, 2024
laurenolivia added a commit that referenced this pull request Feb 15, 2024
laurenolivia added a commit that referenced this pull request Feb 15, 2024
* add changelog entries for #847 and #848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants