Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-9286 Add the enforced attribute to variable_set #778

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

Netra2104
Copy link
Contributor

Description

The variable sets has a new attribute called enforced to disable overwrites and hence go-tfe needs to be updated to accommodate the new attribute as well for POST and PATCH.

Testing plan

Integration tests.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

=== RUN   TestVariableSetsCreate
--- PASS: TestVariableSetsCreate (1.45s)
=== RUN   TestVariableSetsCreate/with_valid_options
    --- PASS: TestVariableSetsCreate/with_valid_options (0.36s)
PASS


=== RUN   TestVariableSetsUpdate
--- PASS: TestVariableSetsUpdate (1.61s)
=== RUN   TestVariableSetsUpdate/when_updating_a_subset_of_values
    --- PASS: TestVariableSetsUpdate/when_updating_a_subset_of_values (0.18s)
=== RUN   TestVariableSetsUpdate/when_options_has_an_invalid_variable_set_ID
    --- PASS: TestVariableSetsUpdate/when_options_has_an_invalid_variable_set_ID (0.00s)
PASS

@Netra2104 Netra2104 requested a review from a team as a code owner September 21, 2023 15:27
brandonc
brandonc previously approved these changes Sep 21, 2023
variable_set_test.go Show resolved Hide resolved
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto

@Netra2104 Netra2104 merged commit c4b9321 into main Sep 21, 2023
10 checks passed
@Netra2104 Netra2104 deleted the Netra2104/TF-9286-enforced-attribute branch September 21, 2023 18:59
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants